Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

render CSV with different delimiters than , #7868

Closed
noerw opened this issue Aug 14, 2019 · 0 comments · Fixed by #7869
Closed

render CSV with different delimiters than , #7868

noerw opened this issue Aug 14, 2019 · 0 comments · Fixed by #7869
Labels
type/enhancement An improvement of existing functionality
Milestone
1.10.0

Comments

@noerw
Copy link
Member

noerw commented Aug 14, 2019

Currently CSV files are only properly rendered with a , delimiter.
; and \t delimiters are common as well, and should be rendered as well.

golangs encoding/csv does not have delimiter detection built in, so we need to implement that.
I'm willing to implement that feature.
noerw added a commit to noerw/gitea that referenced this issue Aug 14, 2019
@noerw
detect csv delimiter in csv rendering
28e5897 
fixes go-gitea#7868
@noerw noerw mentioned this issue Aug 14, 2019
Merged
@lunny lunny added the type/enhancement An improvement of existing functionality label Aug 14, 2019
lafriks pushed a commit that referenced this issue Aug 15, 2019
@noerw @lafriks
Detect delimiter in CSV rendering (#7869)
867f46f 
* detect csv delimiter in csv rendering

fixes #7868

* make linter happy

* fix failing testcase & use ints where possible

* expose markup type to template

previously all markup had the .markdown class, which is incorrect,
as it applies markdown CSS & JS logic to CSV rendering

* fix build (missing `make css`)

* ignore quoted csv content for delimiter scoring

also fix html generation
@lunny lunny added this to the 1.10.0 milestone Aug 16, 2019
@HarvsG HarvsG mentioned this issue Sep 27, 2019
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.10.0
Development

Successfully merging a pull request may close this issue.

Detect delimiter in CSV rendering noerw/gitea
2 participants
@lunny @noerw