Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad default commit message of file upload in root directory #7883

Closed
2 of 7 tasks
noerw opened this issue Aug 15, 2019 · 5 comments · Fixed by #25391
Closed
2 of 7 tasks

Bad default commit message of file upload in root directory #7883

noerw opened this issue Aug 15, 2019 · 5 comments · Fixed by #25391
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/bug

Comments

@noerw
Copy link
Member

noerw commented Aug 15, 2019

Description

Uploading a file and not entering a commit message results in a commit message like Uploaded files to '<dir>'.
When files are uploaded to the root directory, the content inside the quotes is empty.

Screenshots

image

@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI labels Aug 15, 2019
@lafriks
Copy link
Member

lafriks commented Aug 29, 2019

any suggestions on what it should be?

@stale
Copy link

stale bot commented Oct 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Oct 28, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Nov 2, 2019
@stale stale bot removed the issue/stale label Nov 2, 2019
@fnetX
Copy link
Contributor

fnetX commented May 14, 2021

Upload files to '/' sounds better. (Just generally adding a / before the var). Or, setting it to
Upload files to root (without quotes to differ from "root" dir), but this would probably require more than changing one line ...

@zeripath
Copy link
Contributor

@fnetX that seems simplest. Fancy putting the fix in? It's likely a template issue.

@fnetX
Copy link
Contributor

fnetX commented May 15, 2021

It's a translation thing.
editor.upload_files_to_dir = Upload files to '%s'
Should I somehow add the / to the string that is inserted there and hope it doesn't break, or update the locales? If the latter, how does this work? I've only been working as a translator so far, not as someone that changes the original string ...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants