Can not build anymore since version 1.9.0

[ecsgh]

• Gitea version (or commit ref): 1.9.2
• Git version:2.16.4
• Operating system: openSUSE Leap 15.1, openSUSE Leap 15.0, openSUSE Tumbleweed
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

A build using opensuse build service and also local is not possible.
First I want to build gitea in the opensuse build service.
But this fails, because the build process would like to load different packages from github, even though the files actually exist in the vendor directory of the source. The buildservice does not allow external sources to be downloaded during the build process.
Up to version 1.8.2 the build worked without problems.
As of version 1.9.0, this is no longer possible.
Even a build directly does not work. I first download the 1.9.2 release. Unzip the source and change to the directory. then I do the following:
TAGS = "bindata" make generate all
It then appears:
github.com/klauspost/compress/gzip
github.com/blevesearch/bleve/index/scorch
make: *** [Makefile: 315: gitea] Error 1

Why are the files in the vendor directory no longer used?
What do I have to do to reuse it so that I can recreate a package using opensuse buid service?

[typeless]

Which version of go did you use?

[ecsgh]

Version in Leap 15.1: 1.11.10
But i think this is not the problem.
The main problem is, that the vendor dir does not use at build time.

[typeless]

I think 87404d7 should fix the problem.

[lunny]

@typeless right. That's only in v1.10 not v1.9

[sapk]

@ecsgh Can you try those commands ?:

GO111MODULE=on go generate -mod=vendor ./...
GO111MODULE=on go build -mod=vendor -v -tags 'bindata' -ldflags '-s -w -X "main.Version=1.9.2" -X "main.Tags=bindata"' -o ./gitea

[ecsgh]

This bug is not fixed.
When i use:
GO111MODULE=on go generate -mod=vendor ./...
the build service would like to continue to download the vendor packages. But this is not possible in the build service and was not necessary until version 1.8.3. Thus, he does not use the packages in the vendor directory.
When i use only:
GO111MODULE=on go build -mod=vendor -v -tags 'bindata' -ldflags '-s -w -X "main.Version=1.9.2" -X "main.Tags=bindata"' -o ./gitea
then en error rise up:
[ 4s] + go build -mod=vendor -v -tags bindata -ldflags '-s -w -X "main.Version=1.9.2" -X "main.Tags=bindata"' -o ./gitea
[ 4s] code.gitea.io/gitea/modules/options
[ 4s] code.gitea.io/gitea/modules/public
[ 4s] # code.gitea.io/gitea/modules/options
[ 4s] modules/options/static.go:56:12: undefined: Assets
[ 4s] modules/options/static.go:106:12: undefined: Assets
[ 4s] note: module requires Go 1.12# code.gitea.io/gitea/modules/public
[ 4s] modules/public/static.go:15:20: undefined: Assets
[ 4s] note: module requires Go 1.12error: Bad exit status from /var/tmp/rpm-tmp.QNdXNH (%build)

Thus, the build since version 1.9.0 still not possible. What else can I do?
Or. what has changed since 1.9.0?

[lunny]

I think it may related with my PR #7080 that we use github.com/shurcooL/vfsgen.

GO111MODULE=on go generate -mod=vendor ./...

It will run go run -mod=vendor main.go on file

gitea/modules/public/public.go

Line 21 in 171b359

//go:generate go run -mod=vendor main.go

I think maybe go1.11 didn't support go run -mod=vendor but go1.12 support that.

[ecsgh]

Now I have explicitly used go 1.12.
With the command "GO111MODULE = on go generate -mod = vendor. / ...", go continues to load packages from gitub.

For the command "GO111MODULE = on go build -mod = vendor -v -tags 'bindata' -ldflags '-s -w -X" main.Version = 1.9.2 "-X" main.Tags = bindata "' -o. / gitea "comes now only:

[35s] github.com/klauspost/compress/gzip
[35s] golang.org/x/crypto/acme/autocert
[35s] code.gitea.io/gitea/modules/gzip
[35s] github.com/prometheus/client_golang/prometheus/promhttp
[36s] error: Bad exit status from /var/tmp/rpm-tmp.6dnPuC (% ​​build)
[36s]
[36s]
[36s] RPM build errors:
[36s] Bad exit status from /var/tmp/rpm-tmp.6dnPuC (% ​​build)

Which does not help me, because it is not very meaningful.

I still see the public problem or main problem in the attempt to load packages from github.

And again the question. What has changed since 1.9.0, that is always trying to load packages from github and not vendor to use?
Or is something missing at vendor?

[sapk]

What has changed since 1.9.0, that is always trying to load packages from github and not vendor to use? -> a lot but mostly using go module in this case and that by default it doesn't use anymore vendor folder
Or is something missing at vendor? -> it shouldn't

The main problem is go generate command that seems to want to check remote package. (it doesn't necessarily download. It may check the version)
There must be a command in the generate list that doesn't use or honor the -mod=vendor flag.
Since the generate command doesn't pass it will not pass the build command with bindata.

[lunny]

@ecsgh

Could you try the first command as

GO111MODULE=on go generate -mod=vendor -v code.gitea.io/gitea/modules/public code.gitea.io/gitea/modules/options code.gitea.io/gitea/modules/templates