Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: When saving a comment edit, there is no indication of progress or error #8210

Closed
1 of 3 tasks
abread opened this issue Sep 17, 2019 · 3 comments
Closed
1 of 3 tasks
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/enhancement An improvement of existing functionality

Comments

@abread
Copy link

abread commented Sep 17, 2019

Description

Start editing an issue comment.
When you hit save, the edit interface is closed and the only feedback you have of your edit being saved is the comment text changing (when the fetch that sends the edit succeeds).

This is usually fine, but when the network conditions are a bit slower, one gets frustrated not seeing their edit on the screen, and not seeing any sign of progress. It's easier to see when the edit is big or by manipulating the network latency in Chrome/Chromium's DevTools.

When I noticed this I also checked what happens when the request fails by enabling "Offline mode" in Chrome/Chromium's DevTools before clicking save. It just fails silently.

Fix suggestion: It should show an overlay on top of the editing interface to indicate that it is being saved and the user should wait, and only close the interface after it's finished saving. If an error occurs, don't close the edit interface and tell the user it failed.

@lunny lunny added the type/enhancement An improvement of existing functionality label Sep 17, 2019
@stale
Copy link

stale bot commented Nov 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Nov 16, 2019
@abread
Copy link
Author

abread commented Nov 16, 2019

It's still an issue, stale bot, just not a very important one

@stale stale bot removed the issue/stale label Nov 16, 2019
@zeripath zeripath added topic/ui Change the appearance of the Gitea UI kind/usability issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented labels Nov 17, 2019
@wxiaoguang
Copy link
Contributor

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
@delvh delvh added topic/ui-interaction Change the process how users use Gitea instead of the visual appearance and removed topic/ui Change the appearance of the Gitea UI kind/usability labels Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

6 participants