Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Issue Missing Milestone Comment #8644

Closed
jaqra opened this issue Oct 23, 2019 · 3 comments · Fixed by #8678
Closed

New Issue Missing Milestone Comment #8644

jaqra opened this issue Oct 23, 2019 · 3 comments · Fixed by #8678
Labels
type/bug

Comments

@jaqra
Copy link
Contributor

jaqra commented Oct 23, 2019 •
edited
Loading

gitea does not create milestone comment on new issue
I also tried it on try.gitea.io

https://try.gitea.io/jaqra/Foo/issues/4
@jaqra jaqra changed the title Sometimes New Issue Missing Milestone Comment New Issue Missing Milestone Comment Oct 24, 2019
@jaqra
Copy link
Contributor Author

jaqra commented Oct 24, 2019

@lunny

@lunny
Copy link
Member

lunny commented Oct 24, 2019

@jaqra that maybe a bug.

@lunny lunny added the type/bug label Oct 24, 2019
@jaqra
Copy link
Contributor Author

jaqra commented Oct 24, 2019 •
edited
Loading

@lunny look at this https://github.com/go-gitea/gitea/pull/8221/files

before that pr, changeMilestoneAssign creates comment with createMilestoneComment

after that pr, there is no call for changeMilestoneAssign

canges is https://github.com/go-gitea/gitea/pull/8221/files#diff-d5eea3b2c0d4c92d62e12b34eb8da2c0L1122-R1122

@jaqra jaqra mentioned this issue Oct 24, 2019
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make call createMilestoneComment on newIssue func
1 participant
@lunny