-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use separate test repository for Github migration tests #8895
Comments
Right. I think maybe |
Why not fork any of those under go-gitea and use the fork? |
Forking doesn't copy most any of the things actually tested. Just need a set of milestones, issues, releases, etc... @lunny we should use a new repo because you might want to add future tests and that could be hard with an archived repository that you can't modify. Also it might as well be very intentional that the repo only exists to be tested |
@mrsdizzie but you also have to archive it to avoid someone create issues accidentally? |
@lunny it is ok to create new issues (new issues are created on go-gitea/gitea all the time and that is what we test now). We should just have a test repo so there is no reason for anybody to ever modify old issues/milestones/etc... Having a test repo is just like the unit and integration tests we have where it is clear that the information is only there to be tested and you should be cautions if making any additions. |
OK. Here we go. https://github.com/go-gitea/test_repo |
@lunny ok great when I have some time will look into replacing the current tests/data ty! |
@lunny if possible to give me permission to create milestones, release, etc.. if not you should create anything we need to test in that repo then we can update the current tests |
@mrsdizzie Thanks! Done. Now you have permissions to create issues/milestones/releases, etc... on that repository. |
Thx @lunny ill do in a few days when back |
Update all Github migration tests to use a new repo created just for these tests that won't accidentially be modified by regular users interacting with issues. Fixes go-gitea#8895
Update all Github migration tests to use a new repo created just for these tests that won't accidentially be modified by regular users interacting with issues. Fixes #8895
Update all Github migration tests to use a new repo created just for these tests that won't accidentially be modified by regular users interacting with issues. Fixes go-gitea#8895
We should create a test repo that is never touched or modified and use that for github migration tests. As seen in #8893, tests were broke from re-opening an old issue that then changed the modification time of a milestone.
Would be better not to test things that might be updated or change randomly.
The text was updated successfully, but these errors were encountered: