-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minify semantic.dropdown.custom.js #8971
Comments
We can import from edit: #8973 |
I also send a #8975 to allow us pack serval js to index.js. |
@Jookia is there some way to verify whether the customization from #8638 works? For example on https://try.gitea.io/repo/create, I don't see any <div class="ui selection owner dropdown" tabindex="0">
<input type="hidden" id="uid" name="uid" value="476" required="">
<span class="text" title="silverwind"><img class="ui mini image" src="/user/avatar/silverwind/-1">
silverwind</span>
<i class="dropdown icon" tabindex="0"><div class="menu" tabindex="-1"></div></i>
<div class="menu" tabindex="-1">
<div class="item active selected" data-value="476" title="silverwind" tabindex="-1">
<img class="ui mini image" src="/user/avatar/silverwind/-1">
silverwind
</div>
<div class="item" data-value="16251" title="silverwind-org" tabindex="-1">
<img class="ui mini image" src="/user/avatar/silverwind-org/-1">
silverwind-org
</div>
<div class="item" data-value="1069" title="my-cool-organization" tabindex="-1">
<img class="ui mini image" src="/user/avatar/my-cool-organization/-1">
my-cool-organization
</div>
</div>
</div> |
That's not a dropdown menu, it's a dropdown selection. The language selection at the bottom of the page has aria-* attributes |
Thanks, I see the attributes there. |
Also disabled a annoying linter rule which insisted that imports can not contain a file extension. Fixes: go-gitea#8971
* move semantic.dropdown.custom.js to webpack Also disabled a annoying linter rule which insisted that imports can not contain a file extension. Fixes: #8971 * reorganize web_src files and rebuild * restart ci
Thanks to #8598 now
/js/index.js
minified (58KB👍). However,/js/semantic.dropdown.custom.js
(141KB) is still not (it's not a vendored library).The text was updated successfully, but these errors were encountered: