-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tons of panic errors with GZIP enabled #9001
Comments
Ok. We need the precise version of Gitea. routers/repo/repo.go appears to be one of the more active parts of our code so line 342 isn't too helpful. Do you have a SHA hash for the commit that made those logs? |
It would also be helpful to see the router logs and surrounding logging |
Assuming that 1.10 produced that log the implication is that this caused the panic: Line 342 in 9619ccf
Which doesn't exactly make a lot of sense |
Basically either ctx.User is nil or ctx.Repo.Repository / ctx.Repo is nil. |
Assuming that is the causative line, repo.Action matches the following endpoint: gitea/routers/routes/routes.go Line 684 in 9619ccf
|
Which sort of implies that you're try to star a repository but why would you be doing that so often... It's weird. |
It's definitely v1.10.0 . By increasing the log level, I've managed to reproduce the error on my own. So, is it just about a null-able variable being used somewhere ? Thanks for the quick feedback @zeripath 🙇 EDIT (important) : With |
It's weird it's like things are not being cancelled when the user is denied - I'll have to take a look. |
Ah damn... When I reimplemented this I just copied the behaviour that was there before... it was wrong then and it is wrong now. We need to actually properly implement all the context response writer methods - or - change the internal writer of the context response writer. |
Fix go-gitea#9001 The GZIP ProxyReponseWriter doesn't currently respond correctly to requests about its Written status - leading to go-gitea#9001. This PR properly reimplements these methods.
Fix go-gitea#9001 The GZIP ProxyReponseWriter doesn't currently respond correctly to requests about its Written status - leading to go-gitea#9001. This PR properly reimplements these methods.
Fix go-gitea#9001 The GZIP ProxyReponseWriter doesn't currently respond correctly to requests about its Written status - leading to go-gitea#9001. This PR properly reimplements these methods.
Thanks again @zeripath, that was awesome and quick 👌 |
[x]
):Description
Hey everyone !
It seems like there has been some issues with GZIP for some minor versions from now.
I can't really figure out since when, as logs have been polluted and rotated for weeks.
The error attached above is thrown every ~20 seconds when GZIP is enabled on my setup.
Still happening against v1.9.6 and v1.10.0 .
I can provide further details if you guys got some ideas to narrow down the diagnostic.
Bye, thanks 👋
The text was updated successfully, but these errors were encountered: