Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable remote messages on push #9610

Closed
rain0r opened this issue Jan 5, 2020 · 3 comments · Fixed by #9641
Closed

Disable remote messages on push #9610

rain0r opened this issue Jan 5, 2020 · 3 comments · Fixed by #9641
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@rain0r
Copy link

rain0r commented Jan 5, 2020

With the pre- and post-receive calls introduced in #8602, Gitea now sends messages to the pushing client, for example:

remote: * Checking 1 branches
remote: Checked 1 references in total
remote: . Processing 1 references
remote: Processed 1 references in total

Since git always displays this messages, even when called with --quiet, it would be great if these messages could be turned off.

@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Jan 5, 2020
@zeripath
Copy link
Contributor

zeripath commented Jan 5, 2020

So perhaps some explanation is in order.

This was added to prevent pre-receive and post-receive timing out when multiple branches & tags are pushed. By multiple I mean > 100.

Hmm...

Maybe we could stack these up and only display them if you push more than 30 references?

@guillep2k
Copy link
Member

Maybe we could stack these up and only display them if you push more than 30 references?

What about a timer? Many programs show up the progress report only after it's taking longer than a certain time.

If --quiet can be detected on the server side we could print \r instead (which is mostly invisible... except on Mac, of course).

@zeripath
Copy link
Contributor

zeripath commented Jan 7, 2020

I've put a simple PR up that won't print anything if the hook runs for less than one second.

This may need a longer delay or a setting.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants