DeleteRepoFile incorrectly handles Delete to new branch #9752

zeripath · 2020-01-13T23:18:51Z

Whilst looking at #9708 I've noticed that there is an issue with:

Line 49 in 1751d5f

if git.IsErrNotExist(err) {

This should be

if err != nil && !git.IsErrNotExist(err) {

however this breaks several tests which need to also be fixed.

Co-authored-by: zeripath <art27@cantab.net>

zeripath added the type/bug label Jan 13, 2020

zeripath added a commit to zeripath/gitea that referenced this issue Jan 14, 2020

Fix go-gitea#9752

8a8559a

zeripath mentioned this issue Jan 14, 2020

When deleting to a new branch we should expect ErrBranchNotExist #9769

Merged

zeripath closed this as completed in #9769 Jan 14, 2020

zeripath added a commit that referenced this issue Jan 14, 2020

Fix #9752 (#9769)

d171cd4

6543 pushed a commit to 6543-forks/gitea that referenced this issue Jan 14, 2020

Fix go-gitea#9752 (go-gitea#9769)

8acfa2e

sapk pushed a commit that referenced this issue Jan 15, 2020

Fix #9752 (#9769) (#9775)

602c5da

Co-authored-by: zeripath <art27@cantab.net>

go-gitea locked and limited conversation to collaborators Nov 24, 2020

Provide feedback