Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Refactor of IssueWatch related things #10401

Merged
merged 12 commits into from
Feb 26, 2020
Merged

Code Refactor of IssueWatch related things #10401

merged 12 commits into from
Feb 26, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 21, 2020

taken from #9535

@jolheiser jolheiser added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 21, 2020
@jolheiser jolheiser added this to the 1.12.0 milestone Feb 21, 2020
@codecov-io
Copy link

codecov-io commented Feb 21, 2020 •
edited
Loading

Codecov Report

Merging #10401 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10401      +/-   ##
==========================================
+ Coverage   43.69%   43.71%   +0.02%     
==========================================
  Files         586      586              
  Lines       81382    81382              
==========================================
+ Hits        35559    35577      +18     
+ Misses      41420    41404      -16     
+ Partials     4403     4401       -2
Impacted Files Coverage Δ
models/notification.go 64.4% <0%> (+0.84%) ⬆️
modules/log/file.go 77.62% <0%> (+2.09%) ⬆️
services/pull/check.go 55.48% <0%> (+2.43%) ⬆️
services/pull/patch.go 62.89% <0%> (+2.51%) ⬆️
services/pull/temp_repo.go 31.62% <0%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a81942d...e03684b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 21, 2020
@6543
Copy link
Member Author

6543 commented Feb 23, 2020

@lunny -> #10401 (comment)

guillep2k
guillep2k reviewed Feb 23, 2020
View reviewed changes
models/issue_watch.go Outdated Show resolved Hide resolved
models/issue_watch.go Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Feb 23, 2020 •
edited
Loading

@guillep2k if it is a good idear or not ... this pull is still an impruvement in the right direction

about the removeRepository thing ...

(before this pull a explicite unwatch was set !)

@6543
Copy link
Member Author

6543 commented Feb 23, 2020

@guillep2k it all started with #4201

guillep2k
guillep2k approved these changes Feb 23, 2020
View reviewed changes
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a small nit.

models/issue_watch.go Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 23, 2020
@guillep2k
Copy link
Member

I think that the CI fail is related. I restarted the tests a couple of times and it was always blocked in models.createOrUpdateIssueNotifications (among others). Maybe there's a e.Close() missing?

@6543

This comment has been minimized.

Sign in to view
@6543
Copy link
Member Author

6543 commented Feb 24, 2020

make test-mysql Passed (with #10446 and beside https://hastebin.com/kemixeponi.log) on my local pc

@6543
Copy link
Member Author

6543 commented Feb 24, 2020

@lunny found the bug 19e34ff do you have time to look at it again?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 25, 2020
@6543
Copy link
Member Author

6543 commented Feb 25, 2020

ready to 🚀

@guillep2k guillep2k added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 25, 2020
6543 and others added 4 commits February 25, 2020 12:13
@6543
remove Iretating function
b0db088 
LoadWatchUsers do not load Users into IW object and it is used only in api ... so move this logic
@6543
remove unessesary
a904f4b
@6543 @guillep2k
Apply suggestions from code review
b7d08fe 
Thx

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
@6543
make Tests more robust
99867f3
6543
6543 commented Feb 25, 2020
View reviewed changes
models/issue_watch.go Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Feb 25, 2020

wake up lgtm bot

@6543 6543 mentioned this pull request Feb 26, 2020
Closed
@guillep2k guillep2k merged commit 084a2b0 into go-gitea:master Feb 26, 2020
@6543 6543 deleted the refactors_of9535 branch February 26, 2020 09:33
@6543 6543 mentioned this pull request Feb 27, 2020
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillep2k guillep2k guillep2k approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
6 participants
@6543 @codecov-io @guillep2k @lunny @GiteaBot @jolheiser