Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration for deleting orphaned dependencies #10617

Merged
merged 2 commits into from
Mar 5, 2020

Conversation

guillep2k
Copy link
Member

Migration for getting rid of old records; related to #10608

@guillep2k guillep2k added this to the 1.12.0 milestone Mar 5, 2020
@codecov-io
Copy link

codecov-io commented Mar 5, 2020

Codecov Report

Merging #10617 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10617      +/-   ##
==========================================
- Coverage   43.67%   43.62%   -0.05%     
==========================================
  Files         586      587       +1     
  Lines       82167    82174       +7     
==========================================
- Hits        35887    35851      -36     
- Misses      41828    41879      +51     
+ Partials     4452     4444       -8
Impacted Files Coverage Δ
models/migrations/migrations.go 4.16% <ø> (ø) ⬆️
models/migrations/v129.go 0% <0%> (ø)
services/pull/check.go 32.92% <0%> (-17.08%) ⬇️
modules/git/utils.go 65.67% <0%> (-4.48%) ⬇️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
services/pull/pull.go 34.7% <0%> (-1.18%) ⬇️
modules/git/repo.go 46.78% <0%> (-0.92%) ⬇️
routers/repo/view.go 36.14% <0%> (-0.68%) ⬇️
models/pull.go 42.77% <0%> (-0.57%) ⬇️
modules/indexer/stats/db.go 50% <0%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10081f8...dece21e. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 5, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 5, 2020
@sapk sapk merged commit ae452d0 into go-gitea:master Mar 5, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants