Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] confidential Issue #11099

Closed
wants to merge 3 commits into from
Closed

[WIP] confidential Issue #11099

wants to merge 3 commits into from

Conversation

6543
Copy link
Member

@6543 6543 commented Apr 16, 2020 •
edited
Loading

as described in #3217

Who will be able to access: RepAdmin, Assignee, Poster

ToDo

  • FilterFunction
  • create caching table
  • use cached permissions in normal querys as condition
  • create UI things

Take care of:

  • Issue API
  • Comment API
  • reaction API
  • Dashboard
  • Milestone
  • Dependency search
  • notifications
  • IssueCounters ?!?

Notes:

  • creating query builder for "has addmin acces to repo of issue or is assignee or is poster" is getting to big
  • solution: simple filter function where needed + caching who has access to this issue in own table

@6543 6543 changed the title [WIP] Private Issue [WIP] confidential Issue Apr 16, 2020
@stale
Copy link

stale bot commented Jun 15, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Jun 15, 2020
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 15, 2020
@stale stale bot removed the issue/stale label Jun 15, 2020
@6543
Copy link
Member Author

6543 commented Jul 10, 2020

Will have the next 1,5h not many free time - feel free to work on this - after this periotlde I'll do my best to get it in :)

@stale
Copy link

stale bot commented Sep 11, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Sep 11, 2020
@6543
Copy link
Member Author

6543 commented Sep 11, 2020

.

@stale stale bot removed the issue/stale label Sep 11, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Dec 25, 2020
@stale stale bot removed the issue/stale label Apr 15, 2021
@yardenshoham
Copy link
Member

This is in progress for a while now, I'm closing it. Please reopen when it's ready for review.

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@6543 @yardenshoham @GiteaBot