Prevent panic during wrappedConn close at hammertime #11219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <art27@cantab.net>
lafriks
approved these changes
Apr 26, 2020
GiteaBot
added
the
lgtm/need 1
|
Lint error |
zeripath
commented
Apr 26, 2020
Signed-off-by: Andrew Thornton <art27@cantab.net>
guillep2k
approved these changes
Apr 26, 2020
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #11219 +/- ##
=======================================
Coverage 43.19% 43.20%
=======================================
Files 604 604
Lines 86050 86056 +6
=======================================
+ Hits 37170 37180 +10
+ Misses 44288 44286 -2
+ Partials 4592 4590 -2
Continue to review full report at Codecov.
|
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Prevent panic during wrappedConn close at hammertime Signed-off-by: Andrew Thornton <art27@cantab.net> * Update modules/graceful/server.go * Fix extraneous debug in goldmark.go Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reviewing #10549 there is a subtle race during forced shutdown/hammertime that can lead to a panic. This is relatively benign - but it's clearly distracting from the real problem.
Please note this is not the cause of #10549 and will not fix that issue - that issue is a deadlock within the DB.
Signed-off-by: Andrew Thornton art27@cantab.net