Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix submit review form #11252

Merged
merged 5 commits into from
Apr 30, 2020
Merged

Fix submit review form #11252

merged 5 commits into from
Apr 30, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Apr 29, 2020 •
edited
Loading

Restore the large width of the submit review form, and set a smaller minimum height on mobile.

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Fix submit review form
f4b32dd 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Apr 29, 2020
@zeripath zeripath added this to the 1.12.0 milestone Apr 29, 2020
jolheiser
jolheiser reviewed Apr 29, 2020
View reviewed changes
web_src/less/_base.less Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 29, 2020
zeripath added 2 commits April 29, 2020 22:07
@zeripath
placate lint
227ddfa 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath
try something different
049f074 
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
zeripath commented Apr 29, 2020
View reviewed changes
web_src/less/_base.less Outdated Show resolved Hide resolved
6543
6543 approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works 🎉

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 29, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 30, 2020
@silverwind
Copy link
Member

Limiting dropdowns globally probably was a bad idea.

@codecov-io
Copy link

Codecov Report

Merging #11252 into master will increase coverage by 0.03%.
The diff coverage is 31.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11252      +/-   ##
==========================================
+ Coverage   43.25%   43.29%   +0.03%     
==========================================
  Files         601      605       +4     
  Lines       85544    86204     +660     
==========================================
+ Hits        37004    37321     +317     
- Misses      43966    44290     +324     
- Partials     4574     4593      +19
Impacted Files Coverage Δ
modules/indexer/code/indexer.go 38.02% <0.00%> (ø)
modules/indexer/issues/indexer.go 55.94% <0.00%> (-0.25%) ⬇️
modules/markup/markdown/ast.go 0.00% <0.00%> (ø)
modules/markup/markdown/renderconfig.go 0.00% <0.00%> (ø)
modules/markup/markdown/toc.go 0.00% <0.00%> (ø)
modules/migrations/base/pullrequest.go 0.00% <ø> (ø)
modules/migrations/gitlab.go 1.67% <0.00%> (-0.09%) ⬇️
modules/migrations/migrate.go 20.00% <0.00%> (-0.96%) ⬇️
modules/queue/queue_wrapped.go 6.14% <0.00%> (-0.15%) ⬇️
modules/setting/markup.go 1.29% <0.00%> (+0.06%) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33738ff...66b3754. Read the comment docs.

@lunny lunny merged commit cbf5dff into go-gitea:master Apr 30, 2020
@zeripath zeripath deleted the fix-review-form branch April 30, 2020 06:35
@6543 6543 mentioned this pull request Apr 30, 2020
Closed
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@zeripath @techknowlogick
Fix submit review form (go-gitea#11252)
e2b56e2 
* Fix submit review form

Signed-off-by: Andrew Thornton <art27@cantab.net>

* placate lint

Signed-off-by: Andrew Thornton <art27@cantab.net>

* try something different

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Update web_src/less/_base.less

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser left review comments

@6543 6543 6543 approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@CirnoT CirnoT CirnoT approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
10 participants
@zeripath @silverwind @codecov-io @CirnoT @mrsdizzie @6543 @jolheiser @lunny @GiteaBot @techknowlogick