Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tracked time issues #11349

Merged
merged 5 commits into from
May 9, 2020
Merged

Fix tracked time issues #11349

merged 5 commits into from
May 9, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented May 9, 2020

as title

close #11313
fix hidden 500 issue
enable tests 😆

lunny
lunny reviewed May 9, 2020
View reviewed changes
models/issue_tracked_time.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 9, 2020
@6543 6543 mentioned this pull request May 9, 2020
Merged
@codecov-io
Copy link

codecov-io commented May 9, 2020 •
edited
Loading

Codecov Report

Merging #11349 into master will decrease coverage by 0.01%.
The diff coverage is 52.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11349      +/-   ##
==========================================
- Coverage   43.84%   43.82%   -0.02%     
==========================================
  Files         613      613              
  Lines       87221    87226       +5     
==========================================
- Hits        38238    38231       -7     
- Misses      44271    44272       +1     
- Partials     4712     4723      +11
Impacted Files Coverage Δ
models/issue_tracked_time.go 64.53% <40.00%> (+6.11%) ⬆️
routers/api/v1/repo/pull_review.go 64.55% <42.85%> (ø)
routers/api/v1/repo/issue_tracked_time.go 39.63% <100.00%> (+0.89%) ⬆️
models/repo_mirror.go 2.12% <0.00%> (-10.64%) ⬇️
services/pull/update.go 52.54% <0.00%> (-6.78%) ⬇️
services/pull/temp_repo.go 29.05% <0.00%> (-5.13%) ⬇️
modules/git/repo.go 48.11% <0.00%> (-4.19%) ⬇️
services/pull/patch.go 62.93% <0.00%> (-2.80%) ⬇️
services/pull/check.go 53.04% <0.00%> (-2.44%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.93%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9df5da...aef2d11. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 9, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 9, 2020
@guillep2k guillep2k merged commit cd4f7ba into go-gitea:master May 9, 2020
guillep2k pushed a commit to guillep2k/gitea that referenced this pull request May 9, 2020
@6543 @guillep2k
Fix tracked time issues (go-gitea#11349)
e978f3f 
* Fix nil exeption: go-gitea#11313

* fix 500

* activate test 😆

* move logic
@guillep2k guillep2k mentioned this pull request May 9, 2020
Merged
@guillep2k guillep2k added backport/done All backports for this PR have been created type/bug labels May 9, 2020
@guillep2k guillep2k added this to the 1.12.0 milestone May 9, 2020
@6543 6543 deleted the fix-tracked-time-issues branch May 9, 2020 15:24
zeripath pushed a commit that referenced this pull request May 9, 2020
@guillep2k @6543
Fix tracked time issues (#11349) (#11354)
0b216f4 
Backport #11349 

* Fix tracked time issues (#11349)

* Fix nil exeption: #11313

* fix 500

* activate test 😆

* move logic

* Add missing import

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: Guillermo Prandi <guillep2k@users.noreply.github.com>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543
Fix tracked time issues (go-gitea#11349)
9657786 
* Fix nil exeption: go-gitea#11313

* fix 500

* activate test 😆

* move logic
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillep2k guillep2k guillep2k approved these changes

@adelowo adelowo adelowo approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

DELETE time tracking fail with 500 error
6 participants
@6543 @codecov-io @lunny @adelowo @guillep2k @GiteaBot