Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix svg octicon-key placement #11410

Merged
merged 1 commit into from
May 14, 2020
Merged

Fix svg octicon-key placement #11410

merged 1 commit into from
May 14, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 14, 2020

Introduced by #10107

Before:
firefox_2020-05-14_18-30-21

After:
chrome_2020-05-14_18-31-12

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 14, 2020
@jolheiser jolheiser added the topic/ui Change the appearance of the Gitea UI label May 14, 2020
@jolheiser jolheiser added this to the 1.12.0 milestone May 14, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 14, 2020
@zeripath zeripath merged commit 5df72ef into go-gitea:master May 14, 2020
@CirnoT CirnoT deleted the octicon-key_float branch May 15, 2020 00:02
@zeripath zeripath added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels May 17, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@CirnoT
Fix svg octicon-key placement (go-gitea#11410)
b15a99b
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@CirnoT @zeripath @jolheiser @GiteaBot