Fix random avatars #1147
Merged
Fix random avatars #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trusted LGTM |
tboerger
added
the
lgtm/need 1
appleboy
approved these changes
Mar 8, 2017
|
LGTM |
tboerger
added
lgtm/done
fredounnet
reviewed
May 12, 2017
There was a problem hiding this comment.
Hello,
I don't exactly know where, but that code modification doesn't honnor the envar GITEA_CUSTOM.
I can't create organisations anymore from 1.1.0 to 1.1.1. HTTP 500
2017/05/12 12:27:45 [...a/routers/org/org.go:60 CreatePost()] [E] CreateOrganization: generate random avatar: MkdirAll: mkdir /home/xxx/gitea/data: permission denied
gitea runs under systemd control with :
Environment=GITEA_CUSTOM=/home/xxx/gitea
In fact the picture.AVATAR_UPLOAD_PATH entry seems to became mandatory. Then set, there is
no more 500 status.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix random avatars bug and resolve #1131