Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling and padding for commit list on PR view #11588

Merged
merged 2 commits into from
May 23, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 23, 2020

This one was really annoying, had to tweak template to fix the issue.

Before:
chrome_2020-05-23_20-30-37

After:
chrome_2020-05-23_22-12-57
chrome_2020-05-23_22-13-12

Additionally opted for monospace font for commit message itself to differentiate it visually from other events.

@CirnoT
Copy link
Contributor Author

CirnoT commented May 23, 2020

Added fix for missing bold font on author username.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 23, 2020
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label May 23, 2020
@zeripath zeripath added this to the 1.13.0 milestone May 23, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 23, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 23, 2020
@lafriks lafriks merged commit ac3c467 into go-gitea:master May 23, 2020
@lafriks
Copy link
Member

lafriks commented May 23, 2020

Please send backport

@CirnoT CirnoT deleted the commit-list-small branch May 23, 2020 22:15
@CirnoT
Copy link
Contributor Author

CirnoT commented May 23, 2020

@lafriks This PR addresses issue with feature that did not land in v1.12 #11167

ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
* Fix styling and padding for commit list on PR view

* fix bold on author
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants