Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export monaco editor on window.codeEditors #11739

Merged
merged 2 commits into from
Jun 3, 2020
Merged

export monaco editor on window.codeEditors #11739

merged 2 commits into from
Jun 3, 2020

Conversation

silverwind
Copy link
Member

Fixes: #10409

@silverwind silverwind mentioned this pull request Jun 2, 2020
Closed
8 tasks
@jolheiser jolheiser added this to the 1.13.0 milestone Jun 2, 2020
@jolheiser jolheiser added the type/enhancement An improvement of existing functionality label Jun 2, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 3, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 3, 2020
@lafriks
Copy link
Member

lafriks commented Jun 3, 2020

make lg-tm work

@lafriks lafriks merged commit 160c23c into go-gitea:master Jun 3, 2020
@silverwind silverwind deleted the export-code-editor branch June 3, 2020 11:23
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@silverwind @lafriks
export monaco editor on window.codeEditors (go-gitea#11739)
b33f2d4 
Fixes: go-gitea#10409

Co-authored-by: Lauris BH <lauris@nix.lv>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Exposing simpleMDEditor as Javascript object (again)
5 participants
@silverwind @lafriks @zeripath @GiteaBot @jolheiser