Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move gitGraph to own sources and improve it #12131

Closed
wants to merge 1 commit into from
Closed

Move gitGraph to own sources and improve it #12131

wants to merge 1 commit into from

Conversation

silverwind
Copy link
Member

  • "un-vendor" it by moving the function
  • reformatted it, fixed spelling error
  • made the dots the same color as the line which also makes it work better on arc-green
  • hide the area until rendering is done to eliminate flashes of wrong content

@silverwind
Move gitGraph to own sources and improve it
da16e13 
- "un-vendor" it by moving the function
- reformatted it, fixed spelling error
- made the dots the same color as the line which also makes it work
  better on arc-green
- hide the area until rendering is done to eliminate flashes of wrong
  content
@zeripath
Copy link
Contributor

zeripath commented Jul 3, 2020

I'm actually currently rewriting this...

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 3, 2020
@silverwind
Copy link
Member Author

silverwind commented Jul 3, 2020 •
edited
Loading

If you have something more substantial, feel free to incorporate my tweaks there. The dot change is just the line ctx.fillStyle = color;. The hiding is graphCanvas.closest('#git-graph-container').classList.add('in'); and the css rules.

@silverwind silverwind marked this pull request as draft July 3, 2020 19:51
@zeripath zeripath mentioned this pull request Jul 4, 2020
Merged
zeripath added a commit to zeripath/gitea that referenced this pull request Jul 4, 2020
@zeripath
Rewrite GitGraph.js
8c55116 
The current vendored gitgraph.js is no longer maintained and is
difficult to understand, fix and maintain.

This PR completely rewrites its logic - hopefully in a clearer fashion
and easier to maintain.

It also includes @silverwind's improvements of coloring the commit dots
and preventing the flash of incorrect content.

Further changes to contemplate in future will be abstracting out of the
flows to an object, storing the involved commit references on the flows
etc. However, this is probably a required step for this.

Replaces go-gitea#12131
Fixes go-gitea#11981 (part 3)

Signed-off-by: Andrew Thornton <art27@cantab.net>
@silverwind silverwind closed this Jul 5, 2020
zeripath added a commit that referenced this pull request Jul 5, 2020
@zeripath
Rewrite GitGraph.js (#12137)
2ab185d 
The current vendored gitgraph.js is no longer maintained and is
difficult to understand, fix and maintain.

This PR completely rewrites its logic - hopefully in a clearer fashion
and easier to maintain.

It also includes @silverwind's improvements of coloring the commit dots
and preventing the flash of incorrect content.

Further changes to contemplate in future will be abstracting out of the
flows to an object, storing the involved commit references on the flows
etc. However, this is probably a required step for this.

Replaces #12131
Fixes #11981 (part 3)

Signed-off-by: Andrew Thornton <art27@cantab.net>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@zeripath
Rewrite GitGraph.js (go-gitea#12137)
690ce52 
The current vendored gitgraph.js is no longer maintained and is
difficult to understand, fix and maintain.

This PR completely rewrites its logic - hopefully in a clearer fashion
and easier to maintain.

It also includes @silverwind's improvements of coloring the commit dots
and preventing the flash of incorrect content.

Further changes to contemplate in future will be abstracting out of the
flows to an object, storing the involved commit references on the flows
etc. However, this is probably a required step for this.

Replaces go-gitea#12131
Fixes go-gitea#11981 (part 3)

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silverwind @zeripath @GiteaBot