Trim to 255 runes instead of bytes #12150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
Prevents invalid UTF-8 encoding for Description and Website. Refs go-gitea#7905
juergenhoetzel
force-pushed
the
fix-invalid-utf8-encoding
branch
from
eab1d13 to
83550d1
Compare
Ups. Forgot to stage the import. I just amended the commit |
zeripath
reviewed
Jul 5, 2020
zeripath
reviewed
Jul 5, 2020
Co-authored-by: zeripath <art27@cantab.net>
zeripath
approved these changes
Jul 5, 2020
GiteaBot
added
lgtm/need 1
|
So we also need to adjust the database column size. |
255 is still below the current limits: |
|
I don't know why we need to trim the content to 255 runes since it could hold 65535 bytes? |
I also didn't knew. I just wanted to change as little as possible to avoid breaking other parts. Actually according to the DB-schema it's 65536 Codepoints/Runes not bytes. |
lafriks
approved these changes
Jul 7, 2020
GiteaBot
added
lgtm/done
|
🚀 |
|
Please send backport |
techknowlogick
added a commit
that referenced
this pull request
Jul 7, 2020
* Trim to 255 runes instead of bytes Prevents invalid UTF-8 encoding for Description and Website. Refs #7905 * Apply suggestions from code review Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: techknowlogick <matti@mdranta.net> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lauris BH <lauris@nix.lv>
techknowlogick
added
the
backport/done
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Trim to 255 runes instead of bytes Prevents invalid UTF-8 encoding for Description and Website. Refs go-gitea#7905 * Apply suggestions from code review Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: techknowlogick <matti@mdranta.net> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lauris BH <lauris@nix.lv>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents invalid UTF-8 encoding for Description and Website. Refs #7905
Prevents Internal Server errors when repo is created with description > 255 bytes, for example 160*ü (320 bytes):
üüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüüü