Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor webhook payload convertion #12310

Merged
merged 3 commits into from
Sep 5, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Jul 24, 2020

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jul 24, 2020
@lunny lunny added this to the 1.13.0 milestone Jul 24, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 4, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 5, 2020
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an it's getting eaven more easyer to add webhooks :)

@codecov-commenter
Copy link

Codecov Report

Merging #12310 into master will increase coverage by 0.07%.
The diff coverage is 16.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12310      +/-   ##
==========================================
+ Coverage   43.32%   43.39%   +0.07%     
==========================================
  Files         646      647       +1     
  Lines       71625    71487     -138     
==========================================
- Hits        31028    31023       -5     
+ Misses      35582    35442     -140     
- Partials     5015     5022       +7     
Impacted Files Coverage Δ
modules/webhook/discord.go 1.93% <0.00%> (+0.15%) ⬆️
modules/webhook/feishu.go 0.00% <0.00%> (ø)
modules/webhook/msteams.go 0.00% <0.00%> (ø)
modules/webhook/payloader.go 0.00% <0.00%> (ø)
modules/webhook/telegram.go 4.62% <5.55%> (+0.87%) ⬆️
modules/webhook/dingtalk.go 6.81% <6.66%> (+0.84%) ⬆️
modules/webhook/slack.go 30.00% <32.00%> (+2.85%) ⬆️
modules/webhook/matrix.go 34.96% <47.22%> (+4.66%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/indexer/stats/db.go 43.47% <0.00%> (-17.40%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1535c7...0c3a8cf. Read the comment docs.

@techknowlogick techknowlogick merged commit b51bd7f into go-gitea:master Sep 5, 2020
@lunny lunny deleted the lunny/webhook_refactor branch September 5, 2020 09:59
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants