Use transaction in V102 migration #12395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code from dropTableColumns has a slightly confusing portion whereby the session is committed for MSSQL but not for other variants. The v102 migration unfortunately missed this subtlety and did not commit the session. This would lead to data loss in the pull_request table on non-MSSQL versions. Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/bug
issue/critical
silverwind
reviewed
Aug 1, 2020
GiteaBot
added
the
lgtm/need 2
silverwind
approved these changes
Aug 1, 2020
GiteaBot
added
lgtm/need 1
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
changed the title
zeripath
removed
backport/v1.12
issue/critical
|
I've re read this and I see that v102 didn't actually start a transaction so doesn't actually suffer loss - however it really should be in a transaction. |
|
In such case rollback should also be moved out of that function |
lunny
requested changes
Aug 4, 2020
|
@zeripath Why removed the backport label? |
zeripath
changed the title
|
Because I initially thought that this would always cause data loss I put the backport label in - now I understand that it doesn't start a transaction, the data-loss risk is much much lower and so it probably doesn't need backporting. |
lunny
approved these changes
Aug 5, 2020
GiteaBot
added
lgtm/done
|
conflicted. |
|
make lg-tm work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for
dropTableColumnshas a slightly confusing portion whereby the session is committed for MSSQL but not for other variants.The v102 migration doesn't actually start a transaction so this weirdness does not affect it. However it probably should attempt to run this in a transaction.
Signed-off-by: Andrew Thornton art27@cantab.net