-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add files affected by a commit to gitea API -- similar to github #12413
Conversation
Please |
Also you need to update swagger definition |
For any reviewer looking for GH docs, they can be found here: https://docs.github.com/en/rest/reference/repos#get-a-commit |
But if I understand correctly github returns list of objects not strings |
Hi there, I've psuhed a new iteration:
Thanks for your time. |
Still not good for the lint sorry. Let me fix that. |
Codecov Report
@@ Coverage Diff @@
## master #12413 +/- ##
=======================================
Coverage 43.09% 43.09%
=======================================
Files 658 658
Lines 72454 72464 +10
=======================================
+ Hits 31221 31229 +8
Misses 36178 36178
- Partials 5055 5057 +2
Continue to review full report at Codecov.
|
Hi there, Can your guys please take a look and tell me if this is acceptable or not? Thanks a lot for your time, |
now it will not colide and can go in as is :) only one thing: we need tests to make sure it wont break in future :) thanks for the work 👍 |
Thanks a lot for the quick response! |
@jasugun do you need help writting tests? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
@jasugun can you resolve the conflict? |
... or allow maintainers to update the PR to do it for you |
not possible due to forked to an org |
followup: #14579 |
Hi,
The idea is to have ou cis tool track files affected from polled changes at compile time for our gitea projects - as currently possible with github projects.
The current API returns a whole commit tree instead of a simple list of affected files. We'd like to implement this list, just like in github.
Thanks,
Laurent Cahour