Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for diff highlighting #12467

Merged
merged 3 commits into from
Aug 11, 2020

Conversation

mrsdizzie
Copy link
Member

Adding some more tests for different cases to make sure they keep working

Adding some more tests for different cases to make sure they keep working
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 11, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 11, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12467 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12467      +/-   ##
==========================================
- Coverage   43.80%   43.76%   -0.04%     
==========================================
  Files         630      630              
  Lines       69821    69821              
==========================================
- Hits        30583    30558      -25     
- Misses      34299    34318      +19     
- Partials     4939     4945       +6     
Impacted Files Coverage Δ
services/gitdiff/gitdiff.go 73.88% <ø> (+0.66%) ⬆️
services/pull/temp_repo.go 26.59% <0.00%> (-6.39%) ⬇️
modules/sync/unique_queue.go 38.77% <0.00%> (-6.13%) ⬇️
services/pull/update.go 51.92% <0.00%> (-5.77%) ⬇️
modules/git/repo_language_stats.go 52.83% <0.00%> (-3.78%) ⬇️
services/pull/check.go 50.78% <0.00%> (-3.13%) ⬇️
services/pull/patch.go 66.37% <0.00%> (-2.59%) ⬇️
modules/git/repo.go 49.74% <0.00%> (-2.04%) ⬇️
modules/log/event.go 57.54% <0.00%> (-0.95%) ⬇️
services/pull/pull.go 42.03% <0.00%> (-0.24%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4ba1ad...114ba1d. Read the comment docs.

@techknowlogick techknowlogick merged commit 73b155d into go-gitea:master Aug 11, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Aug 11, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants