Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone Issue/Pull List: Add octicons type #12499

Conversation

6543
Copy link
Member

@6543 6543 commented Aug 16, 2020

close #11069

Preview:

Screenshot at 2020-08-16 13-20-08 Screenshot at 2020-08-16 13-20-31

@6543 6543 force-pushed the ui-milestone-issue-pr-list_enhance_11069 branch from 033fa7b to 57be8d2 Compare August 16, 2020 11:24
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2020

Codecov Report

Merging #12499 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12499      +/-   ##
==========================================
+ Coverage   43.54%   43.56%   +0.01%     
==========================================
  Files         637      637              
  Lines       70825    70825              
==========================================
+ Hits        30844    30854      +10     
+ Misses      34978    34973       -5     
+ Partials     5003     4998       -5     
Impacted Files Coverage Δ
models/repo_mirror.go 2.38% <0.00%> (-11.91%) ⬇️
modules/cron/tasks_basic.go 87.35% <0.00%> (-3.45%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-3.27%) ⬇️
services/mirror/mirror.go 18.21% <0.00%> (-1.49%) ⬇️
modules/git/repo.go 49.23% <0.00%> (-0.51%) ⬇️
services/pull/pull.go 41.57% <0.00%> (-0.47%) ⬇️
models/issue_comment.go 53.75% <0.00%> (-0.16%) ⬇️
models/error.go 35.66% <0.00%> (+0.34%) ⬆️
routers/repo/view.go 37.98% <0.00%> (+0.64%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b9e7cf...203acff. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 16, 2020
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Aug 16, 2020
@lafriks lafriks added this to the 1.13.0 milestone Aug 16, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 16, 2020
@silverwind
Copy link
Member

Bit unrelated, but does the issue number need to be so prominent? Maybe move it to the second line similar to GH:

image

@6543
Copy link
Member Author

6543 commented Aug 16, 2020

@silverwind in my opinion I like gitea's look more :)

@silverwind
Copy link
Member

I think it's too distracting, but I can probably put up a PR later to restyle these lists. I think they also aren't properly vertically centered.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 17, 2020
@6543
Copy link
Member Author

6543 commented Aug 17, 2020

@silverwind thanks and 👀 to your pull :)

@techknowlogick techknowlogick merged commit 1984b6a into go-gitea:master Aug 17, 2020
@6543 6543 deleted the ui-milestone-issue-pr-list_enhance_11069 branch August 17, 2020 21:20
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] [Imprufement] Make Issue & Pull different view on Milestone list
6 participants