Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Attachment Settings in the API #12514

Merged
merged 3 commits into from
Sep 5, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Aug 17, 2020

close #12368

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2020

Codecov Report

Merging #12514 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12514   +/-   ##
=======================================
  Coverage   43.39%   43.40%           
=======================================
  Files         647      647           
  Lines       71487    71495    +8     
=======================================
+ Hits        31024    31034   +10     
+ Misses      35445    35437    -8     
- Partials     5018     5024    +6     
Impacted Files Coverage Δ
routers/api/v1/api.go 79.08% <100.00%> (+0.03%) ⬆️
routers/api/v1/settings/settings.go 100.00% <100.00%> (ø)
modules/indexer/stats/db.go 43.47% <0.00%> (-26.09%) ⬇️
modules/indexer/stats/queue.go 52.94% <0.00%> (-23.53%) ⬇️
modules/queue/unique_queue_channel.go 58.06% <0.00%> (-6.46%) ⬇️
modules/log/file.go 73.60% <0.00%> (-1.61%) ⬇️
models/issue_comment.go 53.90% <0.00%> (+0.15%) ⬆️
modules/log/event.go 57.54% <0.00%> (+0.94%) ⬆️
modules/queue/workerpool.go 60.00% <0.00%> (+1.22%) ⬆️
services/mirror/mirror.go 19.93% <0.00%> (+1.35%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bab1204...815d4c7. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 17, 2020
@techknowlogick techknowlogick added modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality labels Aug 17, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Aug 17, 2020
@silverwind
Copy link
Member

Will this conflict #12465? There we will add a new repository.release.ALLOWED_TYPES setting specific to releases.

@6543
Copy link
Member Author

6543 commented Aug 18, 2020

@silverwind looks not - but i think it is good to wait for your pull since then it would make more sence to add some things to other api endpoints ... (allowed for Repo specific ...)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 19, 2020
@6543 6543 force-pushed the api-expose-attachemnt-settings branch from f51d7f9 to df374c3 Compare September 5, 2020 01:47
@6543 6543 changed the title [API] expose attachemnt settings [API] Expose Attachemnt Settings Sep 5, 2020
@6543
Copy link
Member Author

6543 commented Sep 5, 2020

@mrsdizzie done

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 5, 2020
@zeripath zeripath changed the title [API] Expose Attachemnt Settings Expose Attachment Settings in the API Sep 5, 2020
@zeripath zeripath merged commit dba5d82 into go-gitea:master Sep 5, 2020
@zeripath zeripath deleted the api-expose-attachemnt-settings branch September 5, 2020 07:43
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] [API] expose upload-limits on settings endpoint
7 participants