Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show 2FA info on Admin Pannel: Users List #12515

Merged
merged 6 commits into from
Aug 20, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Aug 18, 2020

close #12049

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2020

Codecov Report

Merging #12515 into master will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12515      +/-   ##
==========================================
- Coverage   43.55%   43.50%   -0.06%     
==========================================
  Files         642      642              
  Lines       71009    71010       +1     
==========================================
- Hits        30931    30894      -37     
- Misses      35076    35108      +32     
- Partials     5002     5008       +6     
Impacted Files Coverage Δ
routers/home.go 47.14% <100.00%> (+0.20%) ⬆️
models/repo_mirror.go 2.38% <0.00%> (-11.91%) ⬇️
services/pull/update.go 51.92% <0.00%> (-5.77%) ⬇️
modules/notification/mail/mail.go 32.50% <0.00%> (-3.75%) ⬇️
modules/cron/tasks_basic.go 87.35% <0.00%> (-3.45%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
modules/notification/ui/ui.go 80.55% <0.00%> (-2.78%) ⬇️
modules/log/event.go 57.54% <0.00%> (-1.89%) ⬇️
services/pull/check.go 48.46% <0.00%> (-1.54%) ⬇️
services/mirror/mirror.go 18.21% <0.00%> (-1.49%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5440fc...843b8e9. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 18, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 19, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 19, 2020
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Aug 19, 2020
@zeripath zeripath added this to the 1.13.0 milestone Aug 19, 2020
@lunny lunny merged commit dcb543a into go-gitea:master Aug 20, 2020
@6543 6543 deleted the enhance-list_admin-users-show-2fa branch August 20, 2020 06:42
@zeripath
Copy link
Contributor

zeripath commented Sep 2, 2020

Closes #5414 too

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Admin: User Accounts: show if 2FA is enabled
6 participants