-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git migration UX improvements #12619
Conversation
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #12619 +/- ##
==========================================
+ Coverage 43.39% 43.45% +0.06%
==========================================
Files 645 645
Lines 71288 71304 +16
==========================================
+ Hits 30932 30986 +54
+ Misses 35340 35310 -30
+ Partials 5016 5008 -8
Continue to review full report at Codecov.
|
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Could you consider my propose on #9096 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great as a new base! Probably need to reuse some of this code for the mirror settings in a repo as well which currently have the same username/password issue
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
sidenote: https://try.gitea.io/api/swagger#/repository/repoMigrate has to adapt this if it got merged
had a look how this afect the API ... and the only downside I noticed is that the GitServiceType is an integer so the answer of this pull is: https://gitea.com/gitea/go-sdk/pulls/392 |
@6543 it can be made as enum in API but string could also be easily done imho |
@lafriks if we do so, we should cange it with in v1.13 to not inteoduce a api break |
@6543 yes, that's right |
This PR aims to fix some bugs and improve overall migration UX.
Closes #9096
Bugs
.git
at the end which would cause the client to failIf you would like me to split out the bugs into a separate patch, I could probably take out the GitLab one. The GH one, however, mostly relies on other changes in this PR to get the downloader inside the uploader for retrieving assets with auth.
Enhancements
Overall I hope the UI is a little clearer as to what is expected from the user.
This PR was tested with a private repository on both GitHub/GitLab, and was able to fully migrate everything in both cases.
I was also able to do a plain migration from private repositories on BitBucket as well as Gitea.
UI Example