Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme for line numbers in blame view #12632

Merged
merged 1 commit into from
Aug 29, 2020

Conversation

CL-Jeremy
Copy link
Contributor

A small eye-friendly fix.

Bildschirmfoto 2020-08-29 um 02 48 28

Bildschirmfoto 2020-08-29 um 02 47 03

@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI labels Aug 29, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Aug 29, 2020
@CL-Jeremy
Copy link
Contributor Author

Is there a way to cancel CI on force push 😅

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 29, 2020
@techknowlogick
Copy link
Member

Is there a way to cancel CI on force push

yes, but we purposely have that option disabled in drone as it conflicts with minor parts of our workflow, but thankfully we have pretty significant server capacity available for our CI (we can run 10 builds simultaneously).

@codecov-commenter
Copy link

Codecov Report

Merging #12632 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12632      +/-   ##
==========================================
- Coverage   43.44%   43.42%   -0.02%     
==========================================
  Files         645      645              
  Lines       71328    71328              
==========================================
- Hits        30985    30977       -8     
- Misses      35331    35337       +6     
- Partials     5012     5014       +2     
Impacted Files Coverage Δ
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
modules/log/event.go 56.60% <0.00%> (-0.95%) ⬇️
models/gpg_key.go 54.81% <0.00%> (-0.59%) ⬇️
services/pull/pull.go 41.57% <0.00%> (-0.47%) ⬇️
modules/indexer/stats/db.go 52.17% <0.00%> (ø)
modules/indexer/stats/queue.go 76.47% <0.00%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1eee2d...9666e61. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 29, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 29, 2020
@lafriks lafriks merged commit afd89b1 into go-gitea:master Aug 29, 2020
@CL-Jeremy CL-Jeremy deleted the arc-green-blame-line-no branch August 29, 2020 12:16
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants