Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that all migration requests are cancellable #12669

Merged

Conversation

zeripath
Copy link
Contributor

When doing any requests in migration we should set the context for these requests to ensure that they are cancellable.

Signed-off-by: Andrew Thornton art27@cantab.net

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.13.0 milestone Aug 31, 2020
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath force-pushed the gitlab-migration-should-have-context branch from d646051 to dcb8986 Compare September 1, 2020 17:35
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2020

Codecov Report

Merging #12669 into master will decrease coverage by 0.00%.
The diff coverage is 12.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12669      +/-   ##
==========================================
- Coverage   43.30%   43.29%   -0.01%     
==========================================
  Files         646      646              
  Lines       71593    71625      +32     
==========================================
+ Hits        31004    31011       +7     
- Misses      35575    35604      +29     
+ Partials     5014     5010       -4     
Impacted Files Coverage Δ
modules/migrations/gitlab.go 1.13% <0.00%> (-0.02%) ⬇️
modules/migrations/base/downloader.go 17.64% <5.12%> (-5.72%) ⬇️
modules/migrations/github.go 83.36% <100.00%> (-0.41%) ⬇️
modules/migrations/migrate.go 23.95% <100.00%> (-0.46%) ⬇️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/indexer/stats/db.go 43.47% <0.00%> (-8.70%) ⬇️
modules/migrations/git.go 43.33% <0.00%> (-3.34%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
modules/log/event.go 57.54% <0.00%> (-1.89%) ⬇️
modules/git/repo.go 49.23% <0.00%> (-0.51%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84eac6e...9f5d517. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 1, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 2, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 2, 2020
@techknowlogick techknowlogick merged commit 714ab71 into go-gitea:master Sep 2, 2020
@zeripath zeripath deleted the gitlab-migration-should-have-context branch September 2, 2020 18:46
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants