-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that all migration requests are cancellable #12669
Merged
techknowlogick
merged 4 commits into
go-gitea:master
from
zeripath:gitlab-migration-should-have-context
Sep 2, 2020
Merged
Ensure that all migration requests are cancellable #12669
techknowlogick
merged 4 commits into
go-gitea:master
from
zeripath:gitlab-migration-should-have-context
Sep 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
gitlab-migration-should-have-context
branch
from
September 1, 2020 17:35
d646051
to
dcb8986
Compare
Codecov Report
@@ Coverage Diff @@
## master #12669 +/- ##
==========================================
- Coverage 43.30% 43.29% -0.01%
==========================================
Files 646 646
Lines 71593 71625 +32
==========================================
+ Hits 31004 31011 +7
- Misses 35575 35604 +29
+ Partials 5014 5010 -4
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Sep 1, 2020
lafriks
approved these changes
Sep 2, 2020
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Sep 2, 2020
6543
approved these changes
Sep 2, 2020
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Sep 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing any requests in migration we should set the context for these requests to ensure that they are cancellable.
Signed-off-by: Andrew Thornton art27@cantab.net