Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Restart after install page #12696

Closed
wants to merge 3 commits into from

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Sep 3, 2020

Currently Gitea will simply try to run normally after the install page has completed. This unfortunately doesn't quite work with duplicate log entries and other problems.

This PR causes Gitea to completely restart after the install page has been run.

Signed-off-by: Andrew Thornton art27@cantab.net

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the pr/wip This PR is not ready for review label Sep 3, 2020
Signed-off-by: Andrew Thornton <art27@cantab.net>
return 0, err
}
process, err := os.StartProcess(argv0, os.Args, &os.ProcAttr{
Dir: originalWD,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modules\graceful\restart.go:21:10: undefined: originalWD

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 3, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2020

Codecov Report

Merging #12696 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12696      +/-   ##
==========================================
- Coverage   43.31%   43.29%   -0.02%     
==========================================
  Files         645      646       +1     
  Lines       71527    71596      +69     
==========================================
+ Hits        30981    30997      +16     
- Misses      35540    35584      +44     
- Partials     5006     5015       +9     
Impacted Files Coverage Δ
cmd/web.go 0.00% <0.00%> (ø)
modules/graceful/manager.go 27.10% <0.00%> (-1.93%) ⬇️
modules/graceful/manager_unix.go 32.74% <0.00%> (-3.90%) ⬇️
modules/graceful/net_unix.go 18.34% <ø> (ø)
modules/graceful/restart.go 0.00% <0.00%> (ø)
routers/install.go 0.00% <0.00%> (ø)
routers/private/manager_unix.go 0.00% <0.00%> (ø)
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/sync/unique_queue.go 38.77% <0.00%> (-6.13%) ⬇️
modules/notification/mail/mail.go 34.48% <0.00%> (-3.45%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 514201a...e2d941e. Read the comment docs.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@6543 6543 added the type/enhancement An improvement of existing functionality label Sep 5, 2020
@6543 6543 added this to the 1.14.0 milestone Sep 5, 2020
@zeripath zeripath closed this Oct 18, 2020
@zeripath zeripath deleted the restart-after-install branch October 18, 2020 09:50
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. pr/wip This PR is not ready for review type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants