Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder text for bio profile text form #12792

Merged
merged 2 commits into from
Sep 10, 2020

Conversation

bagasme
Copy link
Contributor

@bagasme bagasme commented Sep 10, 2020

As per title.

  • Add placeholder text
  • Localize

  * Add placeholder text
  * Localize
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2020

Codecov Report

Merging #12792 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12792   +/-   ##
=======================================
  Coverage   43.23%   43.24%           
=======================================
  Files         650      650           
  Lines       72041    72050    +9     
=======================================
+ Hits        31150    31159    +9     
- Misses      35844    35847    +3     
+ Partials     5047     5044    -3     
Impacted Files Coverage Δ
modules/migrations/gitlab.go 1.04% <0.00%> (-0.03%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
modules/git/repo.go 49.23% <0.00%> (-0.51%) ⬇️
models/issue_comment.go 53.75% <0.00%> (-0.16%) ⬇️
services/pull/pull.go 41.57% <0.00%> (ø)
models/error.go 35.66% <0.00%> (+0.34%) ⬆️
models/notification.go 67.04% <0.00%> (+0.91%) ⬆️
modules/process/manager.go 75.00% <0.00%> (+2.50%) ⬆️
modules/notification/ui/ui.go 83.33% <0.00%> (+2.77%) ⬆️
modules/notification/mail/mail.go 37.93% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7354efe...1d125a1. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 10, 2020
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think the wording is ok,
and its always good to have selve describing things ...

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 10, 2020
@6543 6543 added the topic/ui Change the appearance of the Gitea UI label Sep 10, 2020
@6543 6543 added this to the 1.13.0 milestone Sep 10, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 10, 2020
@6543
Copy link
Member

6543 commented Sep 10, 2020

@zeripath ready for 🚀 ?

@zeripath zeripath merged commit 4c42fce into go-gitea:master Sep 10, 2020
@bagasme bagasme deleted the web_src/bio_placeholder branch September 21, 2020 08:49
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants