Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-deleted- #12904

Closed
wants to merge 3 commits into from
Closed

-deleted- #12904

wants to merge 3 commits into from

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 19, 2020

close #12845

@6543 6543 added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Sep 19, 2020
@6543 6543 added this to the 1.14.0 milestone Sep 19, 2020
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 19, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2020

Codecov Report

Merging #12904 into master will increase coverage by 0.08%.
The diff coverage is 7.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12904      +/-   ##
==========================================
+ Coverage   42.99%   43.08%   +0.08%     
==========================================
  Files         658      658              
  Lines       72448    72462      +14     
==========================================
+ Hits        31148    31217      +69     
+ Misses      36260    36193      -67     
- Partials     5040     5052      +12     
Impacted Files Coverage Δ
routers/repo/setting.go 14.64% <0.00%> (-0.31%) ⬇️
routers/routes/routes.go 88.98% <100.00%> (+0.01%) ⬆️
services/pull/check.go 47.69% <0.00%> (-2.31%) ⬇️
modules/git/repo_commit.go 50.54% <0.00%> (-0.73%) ⬇️
models/error.go 34.81% <0.00%> (-0.52%) ⬇️
services/pull/pull.go 41.27% <0.00%> (+0.49%) ⬆️
modules/git/repo.go 46.70% <0.00%> (+0.50%) ⬆️
routers/repo/view.go 38.11% <0.00%> (+0.64%) ⬆️
services/mailer/mail.go 55.91% <0.00%> (+1.07%) ⬆️
modules/notification/notification.go 81.25% <0.00%> (+2.67%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 355788d...3c96e46. Read the comment docs.

@mrsdizzie
Copy link
Member

Add a screenshot ?

@6543
Copy link
Member Author

6543 commented Sep 19, 2020

picture upload on gh dos not work currently

@6543 6543 added the pr/wip This PR is not ready for review label Sep 19, 2020
@6543
Copy link
Member Author

6543 commented Sep 21, 2020

Have a github bug: push to this branch wont do anything ...
... close this pull and open new one

@6543 6543 closed this Sep 21, 2020
@6543 6543 deleted the ui-migration-add-migration-cancel branch September 21, 2020 14:48
@6543
Copy link
Member Author

6543 commented Sep 21, 2020

-> #12917

@6543 6543 removed this from the 1.14.0 milestone Sep 21, 2020
@6543 6543 removed type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. pr/wip This PR is not ready for review labels Sep 21, 2020
@6543 6543 changed the title Ui migration add migration cancel button -deleted- Sep 21, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration: add Cancel button
5 participants