-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slightly simplify the queue settings code to help reduce the risk of problems #12976
Slightly simplify the queue settings code to help reduce the risk of problems #12976
Conversation
…problems Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
- Coverage 42.60% 42.56% -0.04%
==========================================
Files 671 671
Lines 73627 73620 -7
==========================================
- Hits 31368 31338 -30
- Misses 37179 37194 +15
- Partials 5080 5088 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting code comments - like them :)
Codecov Report
@@ Coverage Diff @@
## master #12976 +/- ##
==========================================
+ Coverage 42.05% 42.07% +0.01%
==========================================
Files 681 681
Lines 75121 75114 -7
==========================================
+ Hits 31594 31606 +12
+ Misses 38372 38354 -18
+ Partials 5155 5154 -1
Continue to review full report at Codecov.
|
…ments-in-pull-request-label-style * origin/master: [skip ci] Updated translations via Crowdin Fix diff skipping lines (go-gitea#13154) Update go-version v1.2.3 -> v1.2.4 (go-gitea#13169) Vendor Update Go Libs (go-gitea#13166) Prevent panics with missing storage (go-gitea#13164) Improve users management through the CLI (go-gitea#6001) (go-gitea#10492) Change order of possible-owner organizations to alphabetical (go-gitea#13160) Slightly simplify the queue settings code to help reduce the risk of problems (go-gitea#12976) [Vendor] Update go-ldap to v3.2.4 (go-gitea#13163) [skip ci] Updated translations via Crowdin Update external-renderers.en-us.md (go-gitea#13165)
A recent bug occurred due to a gotcha in the settings code for queues. This code used to do an unnecessary struct to map[string]interface{} conversion that with a small amount renaming is removable.
There a few changes in the helper.go:toConfig() function which allow for more options in future.
Signed-off-by: Andrew Thornton art27@cantab.net