Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return sample message for login error in api context #12994

Merged
merged 7 commits into from
Oct 4, 2020

Conversation

a1012112796
Copy link
Member

As title, will return a sample message instead of full html page.

Signed-off-by: a1012112796 <1012112796@qq.com>
modules/context/auth.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 1, 2020
Co-authored-by: silverwind <me@silverwind.io>
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2020

Codecov Report

Merging #12994 into master will increase coverage by 0.03%.
The diff coverage is 10.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12994      +/-   ##
==========================================
+ Coverage   42.51%   42.54%   +0.03%     
==========================================
  Files         672      672              
  Lines       73699    73715      +16     
==========================================
+ Hits        31336    31365      +29     
+ Misses      37284    37265      -19     
- Partials     5079     5085       +6     
Impacted Files Coverage Δ
modules/context/auth.go 18.47% <10.52%> (-2.58%) ⬇️
models/repo_indexer.go 81.66% <0.00%> (-3.34%) ⬇️
models/repo_language_stats.go 61.73% <0.00%> (-1.74%) ⬇️
modules/indexer/stats/queue.go 64.70% <0.00%> (ø)
services/pull/pull.go 41.27% <0.00%> (+0.49%) ⬆️
models/pull.go 55.17% <0.00%> (+0.62%) ⬆️
modules/queue/unique_queue_channel.go 64.51% <0.00%> (+6.45%) ⬆️
services/pull/check.go 47.69% <0.00%> (+16.15%) ⬆️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 922d698...9fd68df. Read the comment docs.

modules/context/auth.go Outdated Show resolved Hide resolved
modules/context/auth.go Outdated Show resolved Hide resolved
Co-authored-by: Lauris BH <lauris@nix.lv>
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these suggestions read a bit better but otherwise LGTM.

modules/context/auth.go Outdated Show resolved Hide resolved
modules/context/auth.go Outdated Show resolved Hide resolved
modules/context/auth.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 3, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 4, 2020
@techknowlogick techknowlogick added modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality labels Oct 4, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Oct 4, 2020
@techknowlogick techknowlogick merged commit 01c7204 into go-gitea:master Oct 4, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants