Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor NewGitlabDownloader #13103

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Refactor NewGitlabDownloader #13103

merged 1 commit into from
Oct 12, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 11, 2020

as title

@6543 6543 added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Oct 11, 2020
@6543 6543 requested a review from zeripath October 11, 2020 20:40
@6543 6543 mentioned this pull request Oct 11, 2020
Merged
@6543
Copy link
Member Author

6543 commented Oct 11, 2020

If this is to mouch noice i can add it into #12657

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 11, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 11, 2020
@codecov-io
Copy link

Codecov Report

Merging #13103 into master will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13103      +/-   ##
==========================================
+ Coverage   42.51%   42.53%   +0.02%     
==========================================
  Files         673      673              
  Lines       74113    74111       -2     
==========================================
+ Hits        31508    31523      +15     
+ Misses      37486    37469      -17     
  Partials     5119     5119
Impacted Files Coverage Δ
modules/migrations/gitlab.go 1.04% <0.00%> (+<0.01%) ⬆️
modules/indexer/stats/queue.go 64.70% <0.00%> (-11.77%) ⬇️
modules/indexer/stats/db.go 43.47% <0.00%> (-8.70%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
modules/git/repo.go 46.19% <0.00%> (-0.51%) ⬇️
services/gitdiff/gitdiff.go 74.48% <0.00%> (+1.63%) ⬆️
modules/process/manager.go 75.00% <0.00%> (+2.50%) ⬆️
modules/log/event.go 61.79% <0.00%> (+2.83%) ⬆️
modules/charset/charset.go 75.28% <0.00%> (+6.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6413312...84974fc. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 12, 2020
@lunny lunny merged commit 845d0af into go-gitea:master Oct 12, 2020
@6543 6543 deleted the refactor_migrations-gitlab-client branch October 12, 2020 05:13
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @codecov-io @lunny @zeripath @GiteaBot