#13091 - add new mirror button

[divbhasin]

This PR targets #13091. I have tested it manually, and it works. However, I am not sure if this is the best way to do it. I had some trouble on getting URL parameters to carry through to the git service-specific migrate page. Please let me know if there is a better way to get these URL parameters through. I made changes to repo/migrate/migrate.tmpl and repo/migrate.go to accomplish this. The rest is just adding the button.

Screenshots

The screenshots below document the entire flow. The URL params I attached can be seen in the address bar.

[divbhasin]

Any ideas on what's going on with the CI run? I don't know how to fix the build as the error seems to be unrelated to my change.

[techknowlogick]

@divbhasin sometimes there are failed builds due to unrelated failures such as upstream dependencies failing, occasionally it'll be a race condition, although there has been a lot of work to get rid of those. I've restarted your build, and it'll likely pass this build, especially since the same test passed for all other DB types.

[codecov-io]

Codecov Report

Merging #13105 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #13105      +/-   ##
==========================================
+ Coverage   42.17%   42.19%   +0.01%     
==========================================
  Files         684      684              
  Lines       75546    75549       +3     
==========================================
+ Hits        31865    31878      +13     
+ Misses      38459    38449      -10     
  Partials     5222     5222              

Impacted Files	Coverage Δ
routers/org/home.go	67.03% <100.00%> (+0.36%)	⬆️
routers/repo/migrate.go	42.30% <100.00%> (+0.90%)	⬆️
modules/indexer/stats/db.go	60.86% <0.00%> (-8.70%)	⬇️
modules/queue/unique_queue_disk_channel.go	53.84% <0.00%> (-1.54%)	⬇️
services/pull/pull.go	40.78% <0.00%> (ø)
routers/repo/view.go	38.11% <0.00%> (+0.64%)	⬆️
modules/process/manager.go	75.00% <0.00%> (+2.50%)	⬆️
models/unit.go	49.31% <0.00%> (+2.73%)	⬆️
modules/charset/charset.go	73.03% <0.00%> (+4.49%)	⬆️
modules/util/timer.go	85.71% <0.00%> (+42.85%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4d9533...f34927f. Read the comment docs.

[CirnoT]

Looks good although unsure whether we should distinguish the buttons somehow to avoid confusion.

[silverwind]

Needs a condition to not show when repository.DISABLE_MIRRORS is enabled.

[divbhasin]

@silverwind can you have a look, please? The add mirror button does not show now if the option you mentioned is enabled.

[silverwind]

.Org and .Mirror can be nil, I think you need to conditionally add those params only when the are not nil to not break regular migrations.

[divbhasin]

Sorry, but how can .Org be nil? This would be on the homepage of an Org so wouldn't .Org have to exist? Existing migrations from the dropdown to the top right will not be sending org and mirror params. In that case, from the repo selection page (second screenshot), org=&mirror= will be sent, which will have no impact on the form in screenshot 3.

[silverwind]

Ah, probably fine. I misinterpreted the serviceType == 0 part in the code. If that template only renders in that if clause it cannot become nil under regular means.

[techknowlogick]

🚀