Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CSS Variables for fonts, remove postcss-loader #13204

Merged
merged 6 commits into from
Oct 19, 2020
Merged

Use CSS Variables for fonts, remove postcss-loader #13204

merged 6 commits into from
Oct 19, 2020

Conversation

silverwind
Copy link
Member

  • Use CSS variables for fonts, making the fonts easier to customize
  • Remove postcss-loader, it's not doing anything useful and is actually applying strange transforms on our CSS.

Fixes: #11045

silverwind
silverwind commented Oct 18, 2020
View reviewed changes
.stylelintrc Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 18, 2020
@silverwind
Use CSS Variables for fonts, remove postcss-loader
be4eeea 
- Use CSS variables for fonts, making the fonts easier to customize
- Remove postcss-loader, it's not doing anything useful and is actually
  applying strange transforms on our CSS.

Fixes: go-gitea#11045
@techknowlogick techknowlogick added type/refactoring Existing code has been cleaned up. There should be no new functionality. topic/ui Change the appearance of the Gitea UI labels Oct 19, 2020
@techknowlogick techknowlogick added this to the 1.14.0 milestone Oct 19, 2020
@silverwind
Copy link
Member Author

Lint issue worked around via quoting. I also changed single to double quotes. I don't think we enforce a CSS quote style yet, seems like material for another PR.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 19, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 19, 2020
@codecov-io
Copy link

Codecov Report

Merging #13204 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13204      +/-   ##
==========================================
- Coverage   42.03%   42.00%   -0.03%     
==========================================
  Files         683      683              
  Lines       75215    75215              
==========================================
- Hits        31613    31597      -16     
- Misses      38439    38451      +12     
- Partials     5163     5167       +4
Impacted Files Coverage Δ
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
services/pull/check.go 49.63% <0.00%> (-2.19%) ⬇️
services/pull/patch.go 52.84% <0.00%> (-1.71%) ⬇️
modules/git/repo.go 46.19% <0.00%> (-0.51%) ⬇️
services/pull/pull.go 40.78% <0.00%> (-0.50%) ⬇️
modules/indexer/stats/db.go 60.86% <0.00%> (ø)
modules/log/event.go 59.90% <0.00%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05aa6fd...a9641fe. Read the comment docs.

@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 3ddf3f9 into go-gitea:master Oct 19, 2020
@silverwind silverwind deleted the fontvars branch October 19, 2020 20:24
@silverwind silverwind restored the fontvars branch October 19, 2020 20:50
@silverwind silverwind deleted the fontvars branch October 19, 2020 20:52
ivanvc added a commit to ivanvc/gitea that referenced this pull request Oct 21, 2020
@ivanvc
Merge remote-tracking branch 'origin/master' into update-outdated-com…
f5c3a69 
…ments-in-pull-request-label-style

* origin/master: (27 commits)
  [skip ci] Updated translations via Crowdin
  add more clarification to the issue-template.md (go-gitea#13235)
  go-version constraints ignore pre-releases (go-gitea#13234)
  [skip ci] Updated translations via Crowdin
  Update some JS dependencies (go-gitea#13222)
  Return the full rejection message and errors in flash errors (go-gitea#13221)
  Update heatmap fixtures to restore tests (go-gitea#13224)
  [skip ci] Updated translations via Crowdin
  Add review request api (go-gitea#11355)
  [skip ci] Updated translations via Crowdin
  When the git ref is unable to be found return broken pr (go-gitea#13218)
  Various arc-green fixes (go-gitea#13214)
  Show stale label for stale code comment which is marked as resolved (go-gitea#13213)
  Move install pages out of main macaron routes (go-gitea#13195)
  Use CSS Variables for fonts, remove postcss-loader (go-gitea#13204)
  [skip ci] Updated translations via Crowdin
  Align `SSH_AUTHORIZED_KEYS_BACKUP` var with the value in `app.ini` (go-gitea#13212)
  Fix size and clickable area on file table back link (go-gitea#13205)
  [skip ci] Updated translations via Crowdin
  Fix error in diff html rendering (go-gitea#13191)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Use CSS variables for font-family definition
5 participants
@silverwind @codecov-io @techknowlogick @zeripath @GiteaBot