Avatar autogeneration fixed

[pboguslawski]

This mod fixes problem with initial avatar autogeneration and
avatar autogneration after deleting previous avatar.

Related: #13159
Fixes: 80a6b0f
Author-Change-Id: IB#1105243

[codecov-io]

Codecov Report

Merging #13233 into master will increase coverage by 0.00%.
The diff coverage is 20.00%.

@@           Coverage Diff           @@
##           master   #13233   +/-   ##
=======================================
  Coverage   42.21%   42.22%           
=======================================
  Files         683      683           
  Lines       75458    75458           
=======================================
+ Hits        31858    31859    +1     
+ Misses      38377    38375    -2     
- Partials     5223     5224    +1     

Impacted Files	Coverage Δ
models/user.go	54.24% <ø> (+0.06%)	⬆️
routers/user/setting/profile.go	40.22% <0.00%> (-0.71%)	⬇️
models/user_avatar.go	31.57% <100.00%> (ø)
modules/util/timer.go	42.85% <0.00%> (-42.86%)	⬇️
modules/indexer/stats/db.go	52.17% <0.00%> (-8.70%)	⬇️
modules/git/utils.go	73.77% <0.00%> (-3.28%)	⬇️
modules/queue/unique_queue_disk_channel.go	53.84% <0.00%> (-1.54%)	⬇️
modules/git/repo.go	46.19% <0.00%> (-0.51%)	⬇️
services/pull/pull.go	41.27% <0.00%> (+0.49%)	⬆️
services/pull/patch.go	55.68% <0.00%> (+1.70%)	⬆️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9658610...e2252a6. Read the comment docs.

[pboguslawski]

base.HashEmail(u.AvatarEmail) was taken from CreateUser; u.AvatarEmail seems to be protected against "":

gitea/models/user.go

Line 821 in e2252a6

u.AvatarEmail = u.Email

gitea/models/user.go

Line 190 in e2252a6

if len(u.AvatarEmail) == 0 {

[lafriks]

please send backport