-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrations should not fail for comment reactions #13352
Merged
techknowlogick
merged 1 commit into
go-gitea:master
from
zeripath:do-not-fail-migration-for-comment-reactions
Oct 29, 2020
Merged
Migrations should not fail for comment reactions #13352
techknowlogick
merged 1 commit into
go-gitea:master
from
zeripath:do-not-fail-migration-for-comment-reactions
Oct 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An extension to go-gitea#13444 - where we now ensure that comment reaction failures do not cause migrations failure Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #13352 +/- ##
==========================================
- Coverage 42.12% 42.10% -0.02%
==========================================
Files 689 689
Lines 75851 75856 +5
==========================================
- Hits 31949 31936 -13
- Misses 38670 38684 +14
- Partials 5232 5236 +4
Continue to review full report at Codecov.
|
6543
approved these changes
Oct 29, 2020
6 tasks
techknowlogick
approved these changes
Oct 29, 2020
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Oct 29, 2020
An extension to go-gitea#13444 - where we now ensure that comment reaction failures do not cause migrations failure Signed-off-by: Andrew Thornton <art27@cantab.net>
techknowlogick
pushed a commit
that referenced
this pull request
Oct 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
topic/repo-migration
Migrate repos from other platforms to Gitea, or from Gitea to them
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An extension to #13344 - where we now ensure that comment reaction failures do not cause migrations failure
Signed-off-by: Andrew Thornton art27@cantab.net