Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links to repositories in /user/setting/repos #13360

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Fix links to repositories in /user/setting/repos #13360

merged 2 commits into from
Oct 30, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Oct 30, 2020 •
edited
Loading

Somehow the links on /user/setting/repos gained a spurious $ in the links.

Also simplify the enable push pages to allow people to re-enable pushes.

Fix #13359

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Fix links to repositories in /user/setting/repos
c940bed 
somehow the links gained a spurious $ in the links.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.14.0 milestone Oct 30, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 30, 2020
@zeripath zeripath mentioned this pull request Oct 30, 2020
Closed
6 tasks
@zeripath
And fix go-gitea#13359
54002a3 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 30, 2020
@codecov-io
Copy link

Codecov Report

Merging #13360 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13360      +/-   ##
==========================================
+ Coverage   42.09%   42.11%   +0.01%     
==========================================
  Files         689      689              
  Lines       75856    75856              
==========================================
+ Hits        31935    31946      +11     
+ Misses      38687    38676      -11     
  Partials     5234     5234
Impacted Files Coverage Δ
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
services/pull/check.go 48.90% <0.00%> (ø)
modules/git/repo.go 46.70% <0.00%> (+0.50%) ⬆️
routers/repo/view.go 38.11% <0.00%> (+0.64%) ⬆️
services/pull/patch.go 55.68% <0.00%> (+1.70%) ⬆️
models/unit.go 49.31% <0.00%> (+2.73%) ⬆️
services/pull/temp_repo.go 29.78% <0.00%> (+3.19%) ⬆️
modules/git/utils.go 77.04% <0.00%> (+3.27%) ⬆️
modules/avatar/avatar.go 54.76% <0.00%> (+4.76%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 643a0a6...54002a3. Read the comment docs.

@zeripath zeripath merged commit 68bdb9f into go-gitea:master Oct 30, 2020
zeripath added a commit to zeripath/gitea that referenced this pull request Oct 30, 2020
@zeripath
Fix links to repositories in /user/setting/repos (go-gitea#13360)
856364b 
* Fix links to repositories in /user/setting/repos

somehow the links gained a spurious $ in the links.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* And fix go-gitea#13359

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request Oct 30, 2020
Merged
@zeripath zeripath added the backport/done All backports for this PR have been created label Oct 30, 2020
@zeripath zeripath deleted the fix-user-setting-repos branch October 30, 2020 16:29
zeripath added a commit that referenced this pull request Oct 30, 2020
@zeripath
Fix links to repositories in /user/setting/repos (#13360) (#13362)
79d9cda 
* Fix links to repositories in /user/setting/repos

somehow the links gained a spurious $ in the links.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* And fix #13359

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

PR options disappears once unchecked. Can not enable Pull Requests again.
5 participants
@zeripath @codecov-io @6543 @jolheiser @GiteaBot