Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'add code comment' button being invisible all the time (#13389) #13402

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Fix 'add code comment' button being invisible all the time (#13389) #13402

merged 1 commit into from
Nov 2, 2020
+5 −16

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Nov 2, 2020 •
edited
Loading

  • Fix 'add code comment' button being invisible all the time

  • Fix off-center icon

  • Remove old JS hover hack

  • Show on full-line hover

Co-authored-by: techknowlogick techknowlogick@gitea.io

(cherry picked from commit 7f7e7f3)

@CirnoT
Fix 'add code comment' button being invisible all the time (go-gitea#…
4e27253 
…13389)

* Fix 'add code comment' button being invisible all the time

* Fix off-center icon

* Remove old JS hover hack

* Show on full-line hover

Co-authored-by: techknowlogick <techknowlogick@gitea.io>

(cherry picked from commit 7f7e7f3)
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 2, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 2, 2020
@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI labels Nov 2, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Nov 2, 2020
@techknowlogick techknowlogick merged commit cbdbae2 into go-gitea:release/v1.13 Nov 2, 2020
@CirnoT CirnoT deleted the bp-13389 branch November 3, 2020 11:02
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 10, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@CirnoT @mrsdizzie @zeripath @techknowlogick @GiteaBot @6543