Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic bug in handling multiple references in commit #13486

Merged
merged 4 commits into from
Nov 9, 2020
Merged

Fix panic bug in handling multiple references in commit #13486

merged 4 commits into from
Nov 9, 2020

Commits on Nov 9, 2020

  1. Fix panic bug in handling multiple references in commit 

    The issue lay in determining the position of matches on a second run round
a commit message in FindAllIssueReferences.

Fix go-gitea#13483

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    bd25bd6 View commit details
    Browse the repository at this point in the history

  2. Extract function and make testable 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    dfd5174 View commit details
    Browse the repository at this point in the history

  3. Fix the comment 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    9cf3dae View commit details
    Browse the repository at this point in the history

  4. cleaning up the comments a bit more 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    e36643f View commit details
    Browse the repository at this point in the history