Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reply issue by email #13585
reply issue by email #13585
Changes from 22 commits
404ae49
61b9c64
539421d
ca8a716
30d3479
d5dac5d
c95f015
e357517
e6ada29
4800de2
5b5fb6c
77cedeb
074e6d2
4baedb5
08345f0
560f48a
f30caf9
f076123
b00df2e
47df1c9
2923155
4176a92
e881e4c
cffb646
99921b3
65c26ca
68c69bb
4069ceb
3cfe21e
325392e
5589c19
e1948eb
fe2f5e6
9670bc1
0fc7000
f0d9b54
0bad64a
bbb2513
af5a825
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://datatracker.ietf.org/doc/html/rfc2392
The
key
might need to be encoded.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this format is too strict to produce a meaningfull messgae, I wonder.
example of this format:
and github also not use this format:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An word is either an atom or a quoted string.
https://jkorpela.fi/rfc/822addr.html
Positively speaking, this means that the valid constituents of an atom are the following:
Not that strict.
I mean maybe we need a sanitizer or encoder for such format. Otherwise there may be potential bugs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen this block of code at least twice now. What about refactoring into a new function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, but I hasn't found it. can you point it out please? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above, these Message-ID should follow RFC encoding