Fix issue/pull request list assignee filter #13647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The URL contains all the time the assignee in cases where once a type has been selected. Signed-off-by: Karl Heinz Marbaise <kama@soebes.de>
…e time. - The URL contains all the time the assignee in cases where once a type has been selected. - The same behaviour was observed issues viewed via milestones. Signed-off-by: Karl Heinz Marbaise <kama@soebes.de>
Codecov Report
@@ Coverage Diff @@
## master #13647 +/- ##
==========================================
- Coverage 42.20% 42.11% -0.09%
==========================================
Files 697 697
Lines 76577 76579 +2
==========================================
- Hits 32316 32250 -66
- Misses 38960 39048 +88
+ Partials 5301 5281 -20
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
6543
approved these changes
Nov 19, 2020
GiteaBot
added
lgtm/need 1
jolheiser
approved these changes
Nov 19, 2020
GiteaBot
added
lgtm/done
|
ping lgtm |
|
Please send backport to |
jolheiser
changed the title
does this mean I should create another PR against v1.13 branch? |
Yup, a cherrypick would do. For sake of convenience I've created a copy-paste you could use: |
|
backport: #13651 |
khmarbaise
added a commit
to khmarbaise/gitea
that referenced
this pull request
Nov 19, 2020
* Fixes go-gitea#13641 - Filtering in Pull Request kept all the time. - The URL contains all the time the assignee in cases where once a type has been selected. Signed-off-by: Karl Heinz Marbaise <kama@soebes.de> * Followup Fixes go-gitea#13641 - Filtering in Pull Request kept all the time. - The URL contains all the time the assignee in cases where once a type has been selected. - The same behaviour was observed issues viewed via milestones. Signed-off-by: Karl Heinz Marbaise <kama@soebes.de>
jolheiser
pushed a commit
that referenced
this pull request
Nov 19, 2020
* Fixes #13641 - Filtering in Pull Request kept all the time. - The URL contains all the time the assignee in cases where once a type has been selected. Signed-off-by: Karl Heinz Marbaise <kama@soebes.de> * Followup Fixes #13641 - Filtering in Pull Request kept all the time. - The URL contains all the time the assignee in cases where once a type has been selected. - The same behaviour was observed issues viewed via milestones. Signed-off-by: Karl Heinz Marbaise <kama@soebes.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where once a type has been selected.
Signed-off-by: Karl Heinz Marbaise kama@soebes.de