Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in short link processor #13839

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Conversation

mrsdizzie
Copy link
Member

Fixes #13819

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 4, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 4, 2020
@codecov-io
Copy link

Codecov Report

Merging #13839 (a239fb7) into master (c9effd5) will increase coverage by 0.09%.
The diff coverage is 36.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13839      +/-   ##
==========================================
+ Coverage   42.15%   42.25%   +0.09%     
==========================================
  Files         708      708              
  Lines       77167    77168       +1     
==========================================
+ Hits        32529    32604      +75     
+ Misses      39292    39197      -95     
- Partials     5346     5367      +21     
Impacted Files Coverage Δ
modules/markup/html.go 78.83% <36.36%> (+0.03%) ⬆️
models/repo_mirror.go 2.38% <0.00%> (-11.91%) ⬇️
services/pull/check.go 48.90% <0.00%> (-3.65%) ⬇️
modules/cron/tasks_basic.go 87.35% <0.00%> (-3.45%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
services/pull/patch.go 53.97% <0.00%> (-1.71%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
services/mirror/mirror.go 15.98% <0.00%> (-1.17%) ⬇️
services/pull/pull.go 40.68% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9effd5...a239fb7. Read the comment docs.

@6543 6543 merged commit 3512c7e into go-gitea:master Dec 4, 2020
mrsdizzie added a commit to mrsdizzie/gitea that referenced this pull request Dec 4, 2020
@6543 6543 added the backport/done All backports for this PR have been created label Dec 4, 2020
6543 pushed a commit that referenced this pull request Dec 4, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in html.go found from fuzzing
6 participants