Ensure that pusher is not nil preventing panic in push #13945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR go-gitea#13381 refactored notification actions to call NotifyCreateRef and NotifyDeleteRef in a slightly different manner. This leads to the pusher not being set before the call. This PR ensures that the pusher is updated before the call. Fix go-gitea#13940 Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #13945 +/- ##
==========================================
- Coverage 42.22% 42.22% -0.01%
==========================================
Files 710 710
Lines 77207 77211 +4
==========================================
Hits 32599 32599
- Misses 39230 39239 +9
+ Partials 5378 5373 -5
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
6543
approved these changes
Dec 11, 2020
GiteaBot
added
lgtm/need 1
6543
added
the
skip-changelog
mrsdizzie
approved these changes
Dec 11, 2020
GiteaBot
added
lgtm/done
|
Thanks @zeripath . |
|
no problem. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #13381 refactored notification actions to call NotifyCreateRef and
NotifyDeleteRef in a slightly different manner. This leads to the pusher
not being set before the call.
This PR ensures that the pusher is updated before the call.
Fix #13940
Signed-off-by: Andrew Thornton art27@cantab.net