Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whenever the password is updated ensure that the hash algorithm is too (#13966) #13967

Merged
merged 1 commit into from
Dec 13, 2020
Merged

Whenever the password is updated ensure that the hash algorithm is too (#13966) #13967

merged 1 commit into from
Dec 13, 2020

Conversation

zeripath
Copy link
Contributor

Backport #13966

user.HashPassword may potentially - and in fact now likely does - change
the passwd_hash_algo therefore whenever the passwd is updated, this
also needs to be updated.

Fix #13832

Thanks @fblaese for the hint

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Whenever the password is updated ensure that the hash algorithm is too (
c071190 
go-gitea#13966)

Backport go-gitea#13966

`user.HashPassword` may potentially - and in fact now likely does - change
the `passwd_hash_algo` therefore whenever the `passwd` is updated, this
also needs to be updated.

Fix go-gitea#13832

Thanks @fblaese for the hint

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.13.1 milestone Dec 12, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 12, 2020
@zeripath
Copy link
Contributor Author

Make lgtm work

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 13, 2020
@6543 6543 merged commit 8e8e8ee into go-gitea:release/v1.13 Dec 13, 2020
@zeripath zeripath deleted the backport-13966 branch December 15, 2020 21:50
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.1
Development

Successfully merging this pull request may close these issues.
4 participants
@zeripath @mrsdizzie @6543 @GiteaBot